-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add WEBPACK_PACKAGE
env var to use custom webpack
package
#2556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need test, test/build/custom-webpack/custom-webpack.js
with module.exports = require('webpack')
and set WEBPACK_PACKAGE=./custom-webpack.js
WEBPACK_PACKAGE
env var to switch between versions of webpackWEBPACK_PACKAGE
env var to use webpack
package
WEBPACK_PACKAGE
env var to use webpack
packageWEBPACK_PACKAGE
env var to use custom webpack
package
Codecov Report
@@ Coverage Diff @@
## master #2556 +/- ##
==========================================
+ Coverage 90.98% 91.12% +0.13%
==========================================
Files 29 29
Lines 1464 1464
Branches 419 420 +1
==========================================
+ Hits 1332 1334 +2
+ Misses 132 130 -2
Continue to review full report at Codecov.
|
added tests 👍🏻 |
Cache issue? |
Yep, happens only on windows |
@snitin315 Let's wait green #2553 and merge, then rebase |
lets rebase |
38cddca
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
will send PR to documentation
Summary
FIxes #2551
webpack
- run webpack 4WEBPACK_PACKAGE=webpack5
- run webpack 5Does this PR introduce a breaking change?
No
Other information
No