-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generation of negative
flags
#2555
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2555 +/- ##
=======================================
Coverage 90.98% 90.98%
=======================================
Files 29 29
Lines 1464 1464
Branches 419 419
=======================================
Hits 1332 1332
Misses 132 132
Continue to review full report at Codecov.
|
/cc @webpack/cli-team |
@snitin315 we should better to solve it, I will finish your PR, dont' worry |
/cc @webpack/cli-team I want to clarify something here, we have three types:
Here situation when you can use |
Also need review, we should merge it before release |
0c7601f
to
eab6893
Compare
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better
@snitin315 Let's wait green #2553 and merge, then rebase |
eab6893
to
21cf48a
Compare
/cc @webpack/cli-team need merge it the next, I think time to release |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No need
Summary
fix generation of
negative
flags. currently, we have negative flags for all boolean flags regardless ofoption.negative
value.Does this PR introduce a breaking change?
No
Other information
No