-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve error message #2482
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2482 +/- ##
==========================================
+ Coverage 71.86% 71.91% +0.05%
==========================================
Files 46 46
Lines 2182 2186 +4
Branches 581 583 +2
==========================================
+ Hits 1568 1572 +4
Misses 614 614
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add test?
Hard to test 😞, WIP. |
Should be a simple smoketest, I am testing now and will send commits to this PR. |
Done. |
Thanks 🚀 |
Thanks |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
WIP on tests
If relevant, did you update the documentation?
No
Summary
Fixes #2479
Does this PR introduce a breaking change?
No
Other information
No