-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show '--node-env' in minimum help output #2411
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
=======================================
Coverage 71.79% 71.79%
=======================================
Files 46 46
Lines 2177 2177
Branches 574 574
=======================================
Hits 1563 1563
Misses 614 614
Continue to review full report at Codecov.
|
@snitin315 Can you rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can assert on it in help output test
I think we need to use snapshots for |
yep snapshot is better |
eb089a0
to
59af519
Compare
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
already present.
If relevant, did you update the documentation?
Yes
Summary
Show
--node-env
in minimum help output as it is custom flag provided by CLI.--help=verbose
lists too many options not easy to find--node-env
between them.Does this PR introduce a breaking change?
No
Other information
No