-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --node-env flag #2388
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2388 +/- ##
==========================================
+ Coverage 71.74% 71.79% +0.05%
==========================================
Files 47 47
Lines 2173 2177 +4
Branches 573 574 +1
==========================================
+ Hits 1559 1563 +4
Misses 614 614
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need tests, anyway looks good
@snitin315 let's finish, I want to do release, it is very high requested feature |
Need to fix CI, debugging. |
b811c54
to
4f57552
Compare
4f57552
to
2d9dd01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's convert from draft
I will add some complex tests |
💯 |
Thanks |
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
YES WIP
If relevant, did you update the documentation?
YES
Summary
fixes #2362
Does this PR introduce a breaking change?
NO
Other information