-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support esm format for configurations #2381
Conversation
865ac2e
to
c4a50db
Compare
Something has global side effects, it breaks our tests... |
I hate our tests for |
Codecov Report
@@ Coverage Diff @@
## master #2381 +/- ##
==========================================
+ Coverage 71.26% 71.74% +0.47%
==========================================
Files 46 47 +1
Lines 2158 2173 +15
Branches 570 573 +3
==========================================
+ Hits 1538 1559 +21
+ Misses 620 614 -6
Continue to review full report at Codecov.
|
c653648
to
0d92835
Compare
Found the problem, somebody install |
I hate |
8dbd336
to
b19d015
Compare
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
Yep
Summary
fixes #1622
Does this PR introduce a breaking change?
No
Other information
No