-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix error message on invalid plugin options #2380
fix: fix error message on invalid plugin options #2380
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2380 +/- ##
==========================================
+ Coverage 70.50% 70.52% +0.02%
==========================================
Files 47 47
Lines 2156 2158 +2
Branches 561 563 +2
==========================================
+ Hits 1520 1522 +2
Misses 636 636
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀 .
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
No need
Summary
We should not output error stack for validation errors inside plugins
Does this PR introduce a breaking change?
No
Other information
No