-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix entries syntax #2369
[WIP] Fix entries syntax #2369
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2369 +/- ##
==========================================
+ Coverage 70.09% 70.50% +0.40%
==========================================
Files 48 47 -1
Lines 2117 2156 +39
Branches 548 561 +13
==========================================
+ Hits 1484 1520 +36
- Misses 633 636 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Still WIP, |
d2f4cf5
to
c570779
Compare
Impossible to implement:
We need new this on webpack side, webpack accept only string or array of strings (put in my todo) |
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes:
webpack ./entry.js --mode=development
webpack ./entry.js ./other.js --mode=development
webpack build ./entry.js --mode=development
webpack build ./entry.js ./other.js --mode=development
webpack watch ./entry.js --mode=development
webpack serve ./entry.js --mode=development
Summary
fixes #2356
Does this PR introduce a breaking change?
No
Other information
WIP