-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass all argv
to configurations when serve
command used
#2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smoketests again broken, apparently I need to rewrite them again 😞 |
Codecov Report
@@ Coverage Diff @@
## master #2345 +/- ##
==========================================
+ Coverage 68.17% 68.19% +0.01%
==========================================
Files 50 50
Lines 2052 2053 +1
Branches 506 509 +3
==========================================
+ Hits 1399 1400 +1
Misses 653 653
Continue to review full report at Codecov.
|
This was referenced Mar 6, 2021
This was referenced Mar 13, 2021
Merged
Closed
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No need
Summary
fixes #2962 (I think it was fixed, but no, so let's fix)
Does this PR introduce a breaking change?
No
Other information
No