-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show exact package name while prompting for installation #2338
Conversation
2635a0d
to
f1b3130
Compare
Codecov Report
@@ Coverage Diff @@
## master #2338 +/- ##
=======================================
Coverage 68.19% 68.19%
=======================================
Files 51 51
Lines 2053 2053
Branches 506 506
=======================================
Hits 1400 1400
Misses 653 653
Continue to review full report at Codecov.
|
f1b3130
to
f8554d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion.
f8554d8
to
66691e7
Compare
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
N/A
Summary
Currently, the package name that shows up while prompting for installation is the same as the argument supplied as part of
process.argv
. However, this would be misleading if the user supplies the alias or theloader
/plugin
command (generators
).webpack-cli/packages/webpack-cli/lib/webpack-cli.js
Lines 359 to 361 in 767fe6b
Before
After
Does this PR introduce a breaking change?
Nope
Other information
N/A