-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect --stats
, --color
and --no-color
option for serve c…
#2312
Merged
alexander-akait
merged 4 commits into
master
from
fix-respect-stats-and-color-for-serve-command
Jan 6, 2021
Merged
fix: respect --stats
, --color
and --no-color
option for serve c…
#2312
alexander-akait
merged 4 commits into
master
from
fix-respect-stats-and-color-for-serve-command
Jan 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2312 +/- ##
==========================================
- Coverage 67.83% 67.68% -0.15%
==========================================
Files 63 63
Lines 2487 2510 +23
Branches 572 588 +16
==========================================
+ Hits 1687 1699 +12
- Misses 800 811 +11
Continue to review full report at Codecov.
|
We need refactor tests which change cwd |
This was referenced Mar 6, 2021
This was referenced Mar 13, 2021
Merged
Closed
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ommand
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
partial
If relevant, did you update the documentation?
No need
Summary
respect
--stats
,--color
and--no-color
options for webpack serveDoes this PR introduce a breaking change?
No
Other information
Here PR to respect colors - webpack/webpack-dev-middleware#808