-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new configtest command #2303
Conversation
Should we support validating multiple configs simultaneously like Need to discuss /cc @webpack/cli-team |
a2bd00a
to
7814495
Compare
I think it might be not possible for multiple configs as the process will exit as soon as an error config is found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add this package to webpack-cli package.json (in peerDependenciesMeta) too
9e8f03d
to
edd782d
Compare
417075b
to
2de58fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
Feel free to covert it to completed PR from Draft, I think we can merge it |
Let's see how CI run goes. |
Ah, need some tweaks for webpack-4 |
b24f1f1
to
a807a05
Compare
a807a05
to
c2ec3cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #2303 +/- ##
===========================================
+ Coverage 67.81% 86.93% +19.11%
===========================================
Files 63 15 -48
Lines 2486 995 -1491
Branches 572 284 -288
===========================================
- Hits 1686 865 -821
+ Misses 800 130 -670 Continue to review full report at Codecov.
|
c2ec3cd
to
1377748
Compare
/cc @webpack/cli-team need review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need small improve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left few suggestions.
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @alexander-akait Please review the new changes. |
d9c33dd
to
4d1c87d
Compare
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
WIP
If relevant, did you update the documentation?
WIP
Summary
Syntax -
webpack configtest <path-to-config>
Does this PR introduce a breaking change?
No
Other information
Fixes #803