-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the --help
option is working without webpack-dev-server
#2267
Conversation
TODO fix: |
Codecov Report
@@ Coverage Diff @@
## master #2267 +/- ##
==========================================
+ Coverage 67.82% 68.04% +0.22%
==========================================
Files 63 63
Lines 2415 2438 +23
Branches 544 548 +4
==========================================
+ Hits 1638 1659 +21
- Misses 777 779 +2
Continue to review full report at Codecov.
|
Really hard to tests due we use |
@@ -1,8 +0,0 @@ | |||
const WebpackCLITestPlugin = require('../utils/webpack-cli-test-plugin'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have this test in core-flags
, so it is duplicate
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
partial, hard to tests due yarn workspaces
If relevant, did you update the documentation?
No need
Summary
Allow to lazy installation and loading options for commands
Does this PR introduce a breaking change?
No
Other information
fixes #2266