-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce spammy logs #2206
fix: reduce spammy logs #2206
Conversation
need rerun CI after merge - #2208 |
lint fixed in master, we can skip rebase and merge on CI green |
fb60075
to
9c57d42
Compare
Codecov Report
@@ Coverage Diff @@
## master #2206 +/- ##
==========================================
+ Coverage 68.19% 68.54% +0.34%
==========================================
Files 70 70
Lines 2352 2378 +26
Branches 523 535 +12
==========================================
+ Hits 1604 1630 +26
Misses 748 748
Continue to review full report at Codecov.
|
How can this be turned back on? This actually obfuscated some issues I was experiencing. |
Yeah, I would like to know the same -- as this change breaks problem matcher support in VS Code. |
You should not rely on logger output, it is not safe, but you can enable them using https://webpack.js.org/configuration/other-options/#infrastructurelogging (set |
@alexander-akait do you have a suggestion on what to rely on then? |
stats output with |
What is use case? Why you need these lines? |
For VS Code problem matchers -- scraping task (terminal) output to report problems, etc. See: |
In this case please use https://webpack.js.org/configuration/other-options/#infrastructurelogging |
Will that still provide start and stop makers in watch mode? Also the fact that these are now gone by default adds a lot of extra friction for users since they need a custom config for things to "just work" |
Yes, we just decrease log level
It is already works fine, I don't know why you use it in this form, most of developers uses Some developers say - please remove extra logs Sorry, I can't solve this problem for everyone |
I'm totally fine with logs off by default, I was just ignorant as to how to enable them. Your help is much appreciated! |
I thought I was pretty clear as to what we are/were using it for — allowing VS Code to provide a richer build experience when using built tasks. These tasks can just be (and often are) just Also to be clear, I'm only arguing for a start/end marker when in |
If you need some extra logs - PR welcome, we don't remove previous logs, just decrease level |
Also, while I can certainly appreciate the you can't please everyone sentiment (and believe me I get it), I am raising this for a community/ecosystem. I am a core dev on VS Code and the maintainer of the webpack typescript/eslint problem matchers. Yes, I understand that the logs still exist, but we would still like to have the ability to integrate with webpack without a user having to manually alter their configuration -- which was the case before these changes. |
@eamodio Can you open a new issue and describe how you run webpack and what you need, I think we can find solution |
@alexander-akait Sorry for the delay, opened it here: #2374 |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Existing
If relevant, did you update the documentation?
No
Summary
No need extra logs, please disable them by default, so I change
info
tolog
Does this PR introduce a breaking change?
No
Other information
we should output minimum information, stats is enough by default, developers don't love it