-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct usage of cli-flags #2205
Conversation
70f0b4b
to
7b87c61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team
Codecov Report
@@ Coverage Diff @@
## master #2205 +/- ##
=======================================
Coverage 68.19% 68.19%
=======================================
Files 70 70
Lines 2352 2352
Branches 523 523
=======================================
Hits 1604 1604
Misses 748 748
Continue to review full report at Codecov.
|
@@ -114,7 +114,7 @@ const builtInFlags = [ | |||
// Complex configs | |||
{ | |||
name: 'env', | |||
usage: '--env', | |||
usage: '--env <variable> | --env <variable> --env <variable=value>', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think we should also mention that we support nested flags here, var1.var2.var3=value, will PR
/cc @alexander-akait
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
correct usage of cli-flags
Does this PR introduce a breaking change?
No
Other information
No