-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: respect the infrastructureLogging.level
option
#2144
Conversation
/cc @piecyk something missed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Need a lot of changes in tests 😞 WIP |
Yep, that's why the #2036 pr had so many changes. |
10c544b
to
a322e0f
Compare
/cc @snitin315 we need more tests refactor:
you can help me with this |
Yes I can help. Should I do it in this PR or separate? |
|
Codecov Report
@@ Coverage Diff @@
## master #2144 +/- ##
==========================================
+ Coverage 66.15% 68.43% +2.27%
==========================================
Files 72 72
Lines 2340 2341 +1
Branches 516 516
==========================================
+ Hits 1548 1602 +54
+ Misses 792 739 -53
Continue to review full report at Codecov.
|
Hata macos and watching, we really need to stability this tests |
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
No change existing, WIP
If relevant, did you update the documentation?
No
Summary
fixes #2019
Does this PR introduce a breaking change?
No, it is feature
Other information
No