-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect stats
from the config for webpack@4
#2098
Conversation
@@ -641,11 +641,22 @@ class WebpackCLI { | |||
process.exit(2); | |||
} | |||
} else { | |||
logger.raw(`${stats.toString(foundStats)}`); | |||
const printedStats = stats.toString(foundStats); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we use stats: 'none'
we have empty string, so no need to log empty string
Co-authored-by: Anshuman Verma <anshu.av97@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2098 +/- ##
==========================================
+ Coverage 68.49% 68.54% +0.05%
==========================================
Files 75 75
Lines 2390 2394 +4
Branches 496 498 +2
==========================================
+ Hits 1637 1641 +4
Misses 753 753
Continue to review full report at Codecov.
|
lets fix CI |
Fixed |
Windows 😞 |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
fixes #2052
Does this PR introduce a breaking change?
No
Other information
webpack@4 doesn't return
compier
whenwatch: true
in the config, fixed in webpack@5