-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use logger to throw error with proper exit code #2076
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
- Coverage 68.54% 68.50% -0.05%
==========================================
Files 76 76
Lines 2410 2413 +3
Branches 495 495
==========================================
+ Hits 1652 1653 +1
- Misses 758 760 +2
Continue to review full report at Codecov.
|
/cc @webpack/cli-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
/cc @webpack/cli-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
Nope
Summary
user logger for error
Does this PR introduce a breaking change?
No
Other information
No