-
-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pnpm support for package installation #2040
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2040 +/- ##
==========================================
- Coverage 69.01% 69.01% -0.01%
==========================================
Files 85 85
Lines 2443 2446 +3
Branches 493 494 +1
==========================================
+ Hits 1686 1688 +2
- Misses 757 758 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
/cc @webpack/cli-team |
1 similar comment
/cc @webpack/cli-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, needs coverage bump.
@rishabh3112 Changing |
@snitin315 Let's improve it in webpack too for webpack-cli https://github.com/webpack/webpack/blob/master/bin/webpack.js, big thanks for helping |
Sure, I will send a PR. |
@snitin315 big thanks |
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
add
pnpm
support for package installationDoes this PR introduce a breaking change?
No
Other information
No