-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export utils from core for other packages #2011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove template
?
which template @evilebottnawi ? |
From the PR 😄 |
packages/webpack-cli/lib/index.js
Outdated
// export additional utils used by other packages | ||
module.exports.logger = logger; | ||
module.exports.commands = commands; | ||
module.exports.getPackageManager = getPackageManager; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's export this under util
, like webpackCli.util.logger
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do small improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Exported some utils which are used by other packages so we won't depend on the file structure as it can change in core hence it will break other packages.
Does this PR introduce a breaking change?
No
Other information
NA