-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: --config-name behaviour for fuctional configs #2006
Conversation
47cacb6
to
6284a55
Compare
6284a55
to
a09b338
Compare
/cc @webpack/cli-team |
746fcb4
to
7bc69cf
Compare
Should be good now. |
@@ -172,7 +174,15 @@ const finalize = async (moduleObj, args) => { | |||
|
|||
return rawConfig; | |||
}), | |||
); | |||
).then((allConfigs) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using then
, we can use async
/await
safely, I think we need eslint rule for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway good job, thanks!
ccc5b37
to
e175cb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix tests and we can merge
Green CI 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
No
Summary
Fixes #1990
Does this PR introduce a breaking change?
No
Other information