-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: progress supports string argument #2000
Conversation
const isProfile = this.options.progress === 'profile'; | ||
|
||
new ProgressPlugin({ profile: isProfile }).apply(compiler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if an invalid value is provided webpack --progress=invalid
. Should we throw error ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, please review again
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
@evilebottnawi Thanks for your update. I labeled the Pull Request so reviewers will review it again. @snitin315 Please review the new changes. |
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
request from @sokra
Does this PR introduce a breaking change?
No
Other information
No