-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pass a callback to webpack from webpack-cli #1977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One improvement, anyway good job!
Need fix tests and we can merge it, good job, thanks |
@piecyk still broken on windows |
Yep 😞 let's see if clearing .cache will help on windows 🤞 If not, have somewhere old windows laptop 🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work?
@snitin315 yes, it's the same. Thanks. |
40b202f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @anshumanv
Thanks, try to do release today |
What kind of change does this PR introduce?
Refactor how webpack compiler is called from webpack-cli
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No
Other information
Part of #1918