-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow passing strings in env flag #1939
Conversation
It would be good to update the new --env approach at https://webpack.js.org/api/cli/ and also explain how to migrate to version 5 at https://webpack.js.org/migrate/5/ |
Yep, @paulmackinlay I have a PR already - webpack/webpack.js.org#4051 hoping it's merged soon. |
/cc @anshumanv please focus on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests?
…merged and released
Release new version? :D |
What kind of change does this PR introduce?
feat/fix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Need to reflect in docs
Summary
webpack --env platform=app --env production
which will pass
{ platform: "app", production: true }
to the configDoes this PR introduce a breaking change?
Nope
Other information
Fixes #1932