-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: watch mode and options #1931
Conversation
I hate node and windows, but found hacky solution |
@evilebottnawi, sorry about this question. Have you merged? With the webpack-cli version ":" ^ 4.1.0 ", I always have the problem. Thanks so much for all your work. |
@gianlucalarizza No problems with |
@evilebottnawi The only place I have the --watch is in the package.json and not in the webpack configuration options |
Because |
@evilebottnawi |
|
@evilebottnawi
webpack --progress --watch --config webpack.development.js (node:16064) [DEP_WEBPACK_WATCH_WITHOUT_CALLBACK] DeprecationWarning: A 'callback' argument need to be provided to the 'webpack(options, callback)' function when the 'watch' option is set. There is no way to handle the 'watch' option without a callback. |
@gianlucalarizza remove |
@evilebottnawi :) in my package json i have "scripts": { If in my command line I try to remove --watch, it's works fine but i don't have [webpack-cli] watching files for updates... Consider that in the webpack configuration file I have not put the watch option |
You need to remove |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No need
Summary
fixes #1923
Does this PR introduce a breaking change?
No
Other information
We need more tests on this, especial multi compiler mode
stdin is broken, I will fix it in other PR