-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: defer setting default entry to core #1856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big thanks!
/cc @webpack/cli-team
/cc @anshumanv can you fix conflicts? |
0bd209d
@anshumanv CI failed 😞 |
Ah minor issue, fixed 👍 |
Feel free to merge after CI will be green ⭐ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge after CI will be green
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't really understand all of it, but the default entry issue seems fixed 👍
What kind of change does this PR introduce?
We're setting own default entry while core does this already so remove that logic.
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
LMK if there are places which need updates
Summary
Does this PR introduce a breaking change?
No
Other information
Fixes #1852