-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --analyze flag #1853
feat: add --analyze flag #1853
Conversation
5c1b47b
to
12018e1
Compare
4edf4e7
to
770edbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work
/cc @webpack/cli-team
Timeout error on windows CI 😞 . |
execa sometimes buggy on windows, do you have windows? |
Not me, Anyone else with windows @webpack/cli-team ? |
29ffa09
to
8b6d0cf
Compare
862f6e1
to
82b935d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
error(`It looks like ${yellow('webpack-bundle-analyzer')} is not installed.`); | ||
process.exitCode = 2; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we ask to install webpack-bundle-analyzer
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will update.
27a2d15
528a23e
to
27a2d15
Compare
/cc @webpack/cli-team |
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
WIP
If relevant, did you update the documentation?
WIP
Summary
Invoke
webpack-bundle-analyzer
plugin via--analyze
flag.Does this PR introduce a breaking change?
No
Other information
Fixes #1838