fix: resolve dev server hot options correctly

webpack · Nov 2, 2020 · 5a2eb2b · 5a2eb2b
1 parent 4306c4f
commit 5a2eb2b
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/packages/serve/src/createConfig.ts b/packages/serve/src/createConfig.ts
@@ -1,4 +1,8 @@
 import { devServerOptionsType } from './types';
+// eslint-disable-next-line node/no-extraneous-import
+import { version } from 'webpack-dev-server/package.json';
+
+const isDevServer4 = version.startsWith('4');
 
 /**
  *
@@ -18,10 +22,18 @@ export default function createConfig(args): devServerOptionsType {
         // clientLogging is not a valid devServer option
         delete options.clientLogging;
     }
-
-    // only apply hotOnly when both are supplied
-    if (options.hot && options.hotOnly) {
-        delete options.hot;
+    if (isDevServer4) {
+        if (options.hotOnly) {
+            options.hot = 'only';
+            // hotOnly is not a valid devServer option
+            delete options.hotOnly;
+        }
+    } else {
+        // only apply hotOnly when both are supplied
+        if (options.hot && options.hotOnly) {
+            delete options.hot;
+        }
     }
+
     return options;
 }