Skip to content

Commit

Permalink
chore: handle hot flag in dev server
Browse files Browse the repository at this point in the history
  • Loading branch information
anshumanv committed Nov 2, 2020
1 parent 5b1a3c1 commit 2c6d4c9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions packages/serve/src/createConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ import { devServerOptionsType } from './types';
*/
export default function createConfig(args): devServerOptionsType {
const options = { ...args };
let isDevServer4 = false;
let isDevServer4 = false,
devServerVersion;
try {
// eslint-disable-next-line node/no-extraneous-require
const version = require('webpack-dev-server/package.json').version;

isDevServer4 = version.startsWith('4');
devServerVersion = require('webpack-dev-server/package.json').version;
} catch (err) {
throw new Error(`You need to install 'webpack-dev-server' for running 'webpack serve'.\n${err}`);
}
isDevServer4 = devServerVersion.startsWith('4');

if (options.clientLogging) {
options.client = {
Expand Down

0 comments on commit 2c6d4c9

Please sign in to comment.