Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt/Share overlay implementation with create-react-app? #184

Open
kennetpostigo opened this issue Mar 4, 2017 · 4 comments
Open

Adopt/Share overlay implementation with create-react-app? #184

kennetpostigo opened this issue Mar 4, 2017 · 4 comments

Comments

@kennetpostigo
Copy link

kennetpostigo commented Mar 4, 2017

I'm using webpack-hot-middleware for a project and I noticed the overlay(which is quite good) and recently found out about this which is amazing and wondering if maybe we could replicate the effort on the overlay that this middleware already provides. Since both are build on webpack could it be possible to copy paste the overlay they created? @Timer may know more about this and if it's possible.

@Timer
Copy link

Timer commented Mar 4, 2017

Integrating the error overlay should be as simple as adding it as an entrypoint to webpack (or just requiring it somewhere -- it has a global side-effect). If interest is this high for it, it's probably worth releasing as a separate package but I think we want to keep it contained in react-dev-utils for now. I guess once it's merged (any day now), you could require it via react-dev-utils/failFast (or react-dev-utils/errorOverlay).

@glenjamin
Copy link
Collaborator

glenjamin commented Mar 4, 2017

I agree I'd like to have it standalone and pull it in.

It would be nicer to be outside dev-utils but I don't think that's a huge issue as this is a dev-only package anyway.

@glenjamin glenjamin changed the title overlay Adopt/Share overlay implementation with create-react app? May 19, 2017
@glenjamin glenjamin changed the title Adopt/Share overlay implementation with create-react app? Adopt/Share overlay implementation with create-react-app? May 19, 2017
@vinnymac
Copy link

vinnymac commented Jun 13, 2017

Could someone clarify the goal for this issue? From what I have read, I would assume you all want to replace the existing overlay with react-error-overlay, no?

Getting the overlay to work in webpack-hot-middleware (whm) is as simple as this now that it is standalone.

Alternatively if you just want it to work alongside whm you can add react-error-overlay as an entry before your main. Then just use react-error-overlay/middleware after whm in your server like app.use(errorOverlayMiddleware()).

@frenzzy
Copy link

frenzzy commented Oct 3, 2017

With react-error-overlay v2 integration a bit more complex.
For example see integration with webpack dev server: webpackHotDevClient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants