-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Drop custom eslint for Prettier #84
Comments
It’s not clear whether you want to remove ESLint entirely or just disable style rules. |
I intend to deprecate Based on the feedback during conversions, the existing config is a bit restrictive in certain areas. So the end result is Prettier + prettier-eslint with the latter replacing the existing |
I personally think we still need |
Should have been more clear, we will base our style rules off of the config that works with prettier & then extend as we see fit taking into consideration some of the pain points people have highlighted during the first set of conversions to defaults. |
This has been discussed via slack on more than one occasion. Prettier has the benefit of both excellent tooling integration as well as end an future debates about code style.
prettier-eslint
We may as well get this over with if only to limit the amount of rework for the remaining defaults conversions / incoming transfers.
Everything in the
2.0 milestone
should target https://github.com/webpack-contrib/webpack-defaults/tree/next//cc @webpack-contrib/org-maintainers
The text was updated successfully, but these errors were encountered: