This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
feat: add fallback option (options.fallback)
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
approved these changes
Sep 13, 2017
michael-ciniawsky
changed the title
fallback optionfallback option (options.fallback)
|
@michael-ciniawsky for me, |
|
@evilebottnawi Yeah all good, I can't think of anything better either, it will just stay for a while so better discuss yet then later. But not important or anything blocking. Could you rebase please ? I will take a look at #28/#79 later today then |
alexander-akait
force-pushed
the
feature-fallback
branch
from
472b4be
to
091a5fa
Compare
|
@michael-ciniawsky done 👍 |
michael-ciniawsky
added
status: Approved
and removed
priority: 5 (nice to have)
pr_action: Review
status: Pending
labels
This was referenced Mar 21, 2018
This was referenced Oct 21, 2019
This was referenced Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
no tests in repo
If relevant, did you update the README?
yes
Summary
Ref: #82
Does this PR introduce a breaking change?
no
Other information
not required