-
-
Notifications
You must be signed in to change notification settings - Fork 180
Conversation
@@ -44,6 +44,7 @@ module.exports = { | |||
|**`include`**|`{RegExp\|Array<RegExp>}`|`undefined`|Files to `include`| | |||
|**`exclude`**|`{RegExp\|Array<RegExp>}`|`undefined`|Files to `exclude`| | |||
|**`cache`**|`{Boolean\|String}`|`false`|Enable file caching| | |||
|**`cacheKeys`**|`{Function(defaultCacheKeys, file) -> {Object}}`|`defaultCacheKeys => defaultCacheKeys`|Allows you to override default cache keys| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the 3rd param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seconded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't understand 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evilebottnawi sorry. that means "I agree, and have the same comment"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shellscape i don't understand what i will do 😄 3rd param? What is mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @ooflorent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example below:
[
new UglifyJsPlugin({
cache: true,
cacheKeys: (defaultCacheKeys, file, options) => {
// ^^^^^^^
defaultCacheKeys.myCacheKey = 'myCacheKeyValue';
return defaultCacheKeys;
},
})
]
I now understand that my comment was wrong. The signature is correct, the example is not.
3e9acfa
to
142497e
Compare
@@ -44,6 +44,7 @@ module.exports = { | |||
|**`include`**|`{RegExp\|Array<RegExp>}`|`undefined`|Files to `include`| | |||
|**`exclude`**|`{RegExp\|Array<RegExp>}`|`undefined`|Files to `exclude`| | |||
|**`cache`**|`{Boolean\|String}`|`false`|Enable file caching| | |||
|**`cacheKeys`**|`{Function(defaultCacheKeys, file) -> {Object}}`|`defaultCacheKeys => defaultCacheKeys`|Allows you to override default cache keys| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example below:
[
new UglifyJsPlugin({
cache: true,
cacheKeys: (defaultCacheKeys, file, options) => {
// ^^^^^^^
defaultCacheKeys.myCacheKey = 'myCacheKeyValue';
return defaultCacheKeys;
},
})
]
I now understand that my comment was wrong. The signature is correct, the example is not.
README.md
Outdated
[ | ||
new UglifyJsPlugin({ | ||
cache: true, | ||
cacheKeys: (defaultCacheKeys, file, options) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the 3rd argument please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @ooflorent done, need approve 😄
142497e
to
2370e47
Compare
No description provided.