Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with asset modules #656

Merged
merged 2 commits into from
Nov 12, 2020
Merged

fix: compatibility with asset modules #656

merged 2 commits into from
Nov 12, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #655

Breaking Changes

Hope, no

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #656 (bf7e7f4) into master (4e4733d) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   89.55%   89.66%   +0.11%     
==========================================
  Files          11       11              
  Lines         651      658       +7     
  Branches      181      183       +2     
==========================================
+ Hits          583      590       +7     
  Misses         65       65              
  Partials        3        3              
Impacted Files Coverage Δ
src/loader.js 92.50% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dce50d...bf7e7f4. Read the comment docs.

@alexander-akait alexander-akait merged commit bea1f4d into master Nov 12, 2020
@alexander-akait alexander-akait deleted the issue-655 branch November 12, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When reading from webpack5 filesystem cache imported assets from css are not found
1 participant