Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: linkType option #634

Merged
merged 3 commits into from
Oct 22, 2020
Merged

feat: linkType option #634

merged 3 commits into from
Oct 22, 2020

Conversation

cap-Bernardito
Copy link
Member

@cap-Bernardito cap-Bernardito commented Oct 21, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #328

Breaking Changes

document.head doesn't work in IE8.

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #634 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
+ Coverage   89.53%   89.64%   +0.11%     
==========================================
  Files          11       11              
  Lines         640      647       +7     
  Branches      169      176       +7     
==========================================
+ Hits          573      580       +7     
  Misses         64       64              
  Partials        3        3              
Impacted Files Coverage Δ
src/CssLoadingRuntimeModule.js 97.05% <100.00%> (+0.18%) ⬆️
src/index.js 91.70% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e7a0a...ac6b31b. Read the comment docs.

@cap-Bernardito cap-Bernardito changed the title refactor: code hmr feat: linkType option Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants