Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace camelCase option on exportLocalsStyle option #938

Merged
merged 1 commit into from
May 28, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

rename option

Breaking Changes

Yes

BREAKING CHANGE: camelCase option was removed in favor exportLocalsStyle option. Option value should be String. Use camelCase if you option value was true and asIs if you option value was false.

Additional Info

No

BREAKING CHANGE: `camelCase` option was removed in favor `exportLocalsStyle` option. Option value should be `String`. Use `camelCase` if you option value was `true` and `asIs` if you option value was `false`.
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #938 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   99.27%   99.27%   +<.01%     
==========================================
  Files          10       10              
  Lines         411      412       +1     
  Branches      121      122       +1     
==========================================
+ Hits          408      409       +1     
  Misses          3        3
Impacted Files Coverage Δ
src/utils.js 99.23% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7a464...4df6b97. Read the comment docs.

@alexander-akait alexander-akait merged commit 888cca0 into master May 28, 2019
@alexander-akait alexander-akait deleted the feat-implement-exportLocalsStyle-option branch May 28, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant