Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not crash when an assert return null or undefined #1006

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1005

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #1006 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1006   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          10       10           
  Lines         435      435           
  Branches      127      126    -1     
=======================================
  Hits          433      433           
  Misses          2        2
Impacted Files Coverage Δ
src/runtime/getUrl.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e9662...c39258c. Read the comment docs.

@alexander-akait alexander-akait merged commit 6769783 into master Dec 6, 2019
@alexander-akait alexander-akait deleted the fix-do-not-crash-when-assert-return-null-or-undefined branch December 6, 2019 14:16
@charlessuh
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants