Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallets generation with indexes more than 9 #826

Closed
6od9i opened this issue Jun 29, 2023 · 2 comments
Closed

Wallets generation with indexes more than 9 #826

6od9i opened this issue Jun 29, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@6od9i
Copy link
Contributor

6od9i commented Jun 29, 2023

What happened?

There is bug with generation wallets from seed when index has more than 1 symbol, for example:
address of wallet "m/44'/60'/0'/1" same with wallet "m/44'/60'/0'/10" or "m/44'/60'/0'/121"

What are the steps to reproduce?

  • Run createNewCustomChildAccount from BIP32Keystore with pathes "m/44'/60'/0'/1", "m/44'/60'/0'/10" and "m/44'/60'/0'/121"
  • Generate addresses for that wallets
  1. It will be equal

What is the expected behavior?

Need generate diifferent thrue addresses

What is the error thrown?

Wrong addresses for index more than 9

What's the stack trace said?

Wrong addresses for index more than 9

OS version

All versions

Library version

develop branch (and previous)

@6od9i 6od9i added the bug Something isn't working label Jun 29, 2023
@6od9i
Copy link
Contributor Author

6od9i commented Jun 29, 2023

I created PR with fix - #825

@Eirias
Copy link

Eirias commented Nov 24, 2023

@6od9i You probably should close this issue when the PR is merged.

@6od9i 6od9i closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants