Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-4844 support #2000

Merged
merged 10 commits into from
Feb 13, 2024
Merged

EIP-4844 support #2000

merged 10 commits into from
Feb 13, 2024

Conversation

NickSneo
Copy link
Contributor

@NickSneo NickSneo commented Jan 16, 2024 •
edited
Loading

What does this PR do?

Adds support for EIP-4844

Where should the reviewer start?

Review all files

Why is it needed?

Closes #1979

@NickSneo
initial commit for EIP-4844
dfcc17b 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@NickSneo
added blob, commitment, proof support
021bb65 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@codecov Codecov
Copy link

codecov bot commented Jan 26, 2024 •
edited
Loading

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (36d778b) 68.65% compared to head (e199d7f) 68.94%.

Files Patch % Lines
...web3j/crypto/transaction/type/Transaction4844.java 85.41% 12 Missing and 2 partials ⚠️
crypto/src/main/java/org/web3j/crypto/Blob.java 30.76% 9 Missing ⚠️
...src/main/java/org/web3j/crypto/RawTransaction.java 66.66% 2 Missing ⚠️
...main/java/org/web3j/crypto/TransactionDecoder.java 96.49% 1 Missing and 1 partial ⚠️
...ypto/src/main/java/org/web3j/crypto/BlobUtils.java 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2000      +/-   ##
============================================
+ Coverage     68.65%   68.94%   +0.28%     
- Complexity     3040     3087      +47     
============================================
  Files           490      493       +3     
  Lines         12715    12911     +196     
  Branches       1653     1661       +8     
============================================
+ Hits           8730     8902     +172     
- Misses         3501     3522      +21     
- Partials        484      487       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickSneo
added trsuted setup file
40f6f15 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@NickSneo
fixed rlp decoding and encoding
8a7a582 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
gtebrean
gtebrean reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@gtebrean gtebrean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, also add test cases for this.

besu/build.gradle Outdated Show resolved Hide resolved
abi/src/main/java/org/web3j/abi/datatypes/Bytes.java Outdated Show resolved Hide resolved
crypto/src/main/java/org/web3j/crypto/BlobUtils.java Outdated Show resolved Hide resolved
crypto/src/main/java/org/web3j/crypto/BlobUtils.java Show resolved Hide resolved
cfelde
cfelde reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@cfelde cfelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments/suggestions and questions.

I think test cases will confirm the question, specifically, the ability to submit a 4844 while just providing the blobs and have Web3j manage the proofs and related.

abi/src/main/java/org/web3j/abi/datatypes/Bytes.java Outdated Show resolved Hide resolved
abi/src/main/java/org/web3j/abi/datatypes/Bytes.java Outdated Show resolved Hide resolved
besu/build.gradle Outdated Show resolved Hide resolved
crypto/src/main/java/org/web3j/crypto/BlobUtils.java Outdated Show resolved Hide resolved
crypto/src/main/java/org/web3j/crypto/RawTransaction.java Show resolved Hide resolved
crypto/src/main/java/org/web3j/crypto/transaction/type/Transaction4844.java Show resolved Hide resolved
@NickSneo
consensys repo added to main gradle.build
96b0857 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@NickSneo
tests added, failing build
9e90f63 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@NickSneo
added all tests, tested on Sepolia network
c9d10a8 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@NickSneo NickSneo marked this pull request as ready for review February 5, 2024 23:07
@NickSneo NickSneo mentioned this pull request Feb 6, 2024
Closed
@NickSneo
fixed java dump crash
5254756 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
cfelde
cfelde suggested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@cfelde cfelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions for review/discussion

crypto/src/main/java/org/web3j/crypto/Blob.java Show resolved Hide resolved
crypto/src/main/java/org/web3j/crypto/BlobUtils.java Outdated Show resolved Hide resolved
crypto/src/main/java/org/web3j/crypto/BlobUtils.java Outdated Show resolved Hide resolved
@NickSneo
fixed comments, and loading of KZG lib
14bd0f2 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@NickSneo
load lib fix and simplification
e199d7f 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
gtebrean
gtebrean reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@gtebrean gtebrean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

build.gradle
@@ -21,10 +21,12 @@ ext {
jnr_unixsocketVersion = '0.38.17'
okhttpVersion = '4.9.0'
rxjavaVersion = '2.2.2'
slf4jVersion = '1.7.30'
slf4jVersion = '2.0.11'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move to 2.0.12, is the latest one

@NickSneo NickSneo merged commit a3679af into master Feb 13, 2024
6 checks passed
@michaelnetter michaelnetter mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijeetbhagat abhijeetbhagat abhijeetbhagat left review comments

@cfelde cfelde cfelde requested changes

@gtebrean gtebrean gtebrean approved these changes

@conor10 conor10 Awaiting requested review from conor10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EIP-4844 support
4 participants
@NickSneo @cfelde @abhijeetbhagat @gtebrean