web3js deviates from the Error handling standard

[moshmage]

on the creation of a ContractExecutionError that extends a Web3ContractError (that ultimately extends an Error) the code starts the super class (eventually starting the Error) with a pre-defined message ("Error happened while trying to execute a function inside a smart contract") and appends the original error in a innerError prop.

This causes a deviance from Error handling standards, as a developer I'd like to know the actual stack and error message, and cause, that came along.

I propose to use the cause standard and call super('message', {cause: rpcError})

Expected behavior

• Errors to use {cause: error}

Actual behavior

• Errors use innerError

Steps to reproduce the behavior

Check this line, https://github.com/web3/web3.js/blob/4.x/packages/web3-errors/src/errors/contract_errors.ts#L222

Environment

• web3js 4.1.0

[jdevcs]

Thanks for details and proposing improvement, We will discuss this in team.

[calmacfadden]

This issue impacts the ethereum remix ide.
ethereum/remix-project#4241

[mconnelly8]

Need to investigate