-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor oneOf
Formatting to be More Generic
#5370
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
This is the fix that's specific to
blockSchema.transactions
, and needs to be refactored to be more general.It's checking if the first value in the
transactions
array is a hash or a transaction object and uses the corresponding schemaOriginally posted by @spacesailor24 in #5363 (comment)
Additionally, if one of the schemas defined by
oneOf
is an array of items that need to be formatted (e.g.blockSchema.transacitons
), they're not currently being formatted i.e. When formatting a block the array of transaction hashes or object will always be returned using hex strings instead of whatever data format the user specifies#5363 (review)
The text was updated successfully, but these errors were encountered: