Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor oneOf Formatting to be More Generic #5370

Open
spacesailor24 opened this issue Aug 22, 2022 · 3 comments
Open

Refactor oneOf Formatting to be More Generic #5370

spacesailor24 opened this issue Aug 22, 2022 · 3 comments
Labels
4.x 4.0 related

Comments

@spacesailor24
Copy link
Contributor

spacesailor24 commented Aug 22, 2022

This is the fix that's specific to blockSchema.transactions, and needs to be refactored to be more general.
It's checking if the first value in the transactions array is a hash or a transaction object and uses the corresponding schema

Originally posted by @spacesailor24 in #5363 (comment)


Additionally, if one of the schemas defined by oneOf is an array of items that need to be formatted (e.g. blockSchema.transacitons), they're not currently being formatted i.e. When formatting a block the array of transaction hashes or object will always be returned using hex strings instead of whatever data format the user specifies


#5363 (review)

@spacesailor24 spacesailor24 added the 4.x 4.0 related label Aug 22, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Oct 23, 2022
@mconnelly8 mconnelly8 removed the Stale Has not received enough activity label Nov 1, 2022
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Jan 1, 2023
@nikoulai nikoulai removed the Stale Has not received enough activity label Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Mar 5, 2023
@mconnelly8 mconnelly8 removed the Stale Has not received enough activity label Apr 5, 2023
@mconnelly8 mconnelly8 reopened this Apr 5, 2023
@luu-alex luu-alex mentioned this issue Jul 15, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

No branches or pull requests

3 participants