Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Conflict with bits-ui only in dev mode #3411

Closed
melMass opened this issue Sep 8, 2024 · 6 comments
Closed

[Bug]: Conflict with bits-ui only in dev mode #3411

melMass opened this issue Sep 8, 2024 · 6 comments
Labels
🐞 bug Something isn't working

Comments

@melMass
Copy link

melMass commented Sep 8, 2024

Version

System:
    OS: Windows 11 10.0.22631
    CPU: (24) x64 12th Gen Intel(R) Core(TM) i9-12900K
    Memory: 100.58 GB / 127.75 GB
Browsers:
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.22621.3527
npmPackages:
    @rsbuild/core: 1.0.1-rc.5 => 1.0.1-rc.5
    @rsbuild/plugin-svelte: 1.0.1-rc.5 => 1.0.1-rc.5

Details

I have this client error only in the dev server when importing bits-ui, builds work fine:

Uncaught TypeError: _callbacks_js__WEBPACK_IMPORTED_MODULE_16__ is undefined

image

Reproduce link

https://github.com/melMass/reproduction/tree/js/rsbuild-bitsui

Reproduce Steps

  • Bootstrap my reproduction:
    git clone https://github.com/melMass/reproduction
    cd reproduction
    git checkout js/rsbuild-bitsui
    pnpm install
    pnpm run dev
  • Open the client and check the console
@melMass melMass added the 🐞 bug Something isn't working label Sep 8, 2024
@witsaint
Copy link

witsaint commented Sep 9, 2024

Circular dependency causes this error, and webpack behaves the same as rsbuild, A large number of Circular dependency detected through the CircularDependencyPlugin in the @melt-ui

It might be better to let @melt-ui fit webpack or rspack/ rsbuild

@melMass
Copy link
Author

melMass commented Sep 9, 2024

Thanks I will cross the issue with bits-ui's repo.
Are bits-ui and melt-ui related? I don't see any link between the two

@witsaint
Copy link

witsaint commented Sep 9, 2024

Are bits-ui and melt-ui related? I don't see any link between the two

package.json#57

There is no webpack based example for this library,You can give the library an issue or pr to make the library better

@melMass
Copy link
Author

melMass commented Sep 9, 2024

Thanks @witsaint !
I will bubble it up to both projects as I still don't get the "traceback" of the error.
I will keep this issue open for reference until solved

@chenjiahan
Copy link
Member

Since it is a problem with the third-party library, this issue will be closed. If it involves changes to Rsbuild, please feel free to open it.

@melMass
Copy link
Author

melMass commented Sep 29, 2024

Np! I'll post here if there is a resolution. My project is a desktop app using Webview so dev mode isn't as crucial for me but it would be a DX improvement still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants