Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Doc]: Wrong link in documentation: Source Build Plugin -> Configuring Sub-projects #2394

Closed
konrazem opened this issue May 20, 2024 · 2 comments · Fixed by #2396
Closed
Labels
🐞 bug Something isn't working

Comments

@konrazem
Copy link

Version

System:
    OS: Windows 11 10.0.22631
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
    Memory: 32.31 GB / 63.74 GB
  Browsers:
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.22621.3527

Details

In If the sub-project uses exports field, you also need to add the source field in the exports field. exports has wrong link.

I think it should be:
https://nodejs.org/api/packages.html#package-entry-points

Reproduce link

https://rsbuild.dev/plugins/list/plugin-source-build#configuring-sub-projects

Reproduce Steps

Check documentation and a link provided.

I didn't find bug type dedicated to documentation. I am sorry for such small issue it is not a BUG at the end just a documentation improvement

@konrazem konrazem added the 🐞 bug Something isn't working label May 20, 2024
@SoonIter
Copy link
Member

I think it should be:
nodejs.org/api/packages.html#package-entry-points

Yeah, I think it has something to do with the adjustment of node's official website. We can fix these wrong links.

I didn't find bug type dedicated to documentation. I am sorry for such small issue it is not a BUG at the end just a documentation improvement

Thank you for the contribution. It's an important feedback. Every step matters for the improvement of rsbuild

@chenjiahan
Copy link
Member

Fixed, thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants