-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please update docs for 4.8 (deprecations toward 5.0) #570
Comments
Bumping this one up as well, waiting for the documentation on the 4.8v. as right now after update, the As when it is used like that only
It gives
After adding a proper encoder as an argument, it is still raising some issues
Neither it works when I pass serializer into deprecated Everything was working <4.8. I can provide more debugging information if needed, but the proper documentation on using deserializer and new ceremony step manager would be very very helpful. |
Hello @ptmkenny, @Jorgu5 and al, I am really sorry for the inconvenience. The serializer or the ceremony steps should be optional in 4.x, but it is not the case and not working as expected. I need time to rework and fix it. I will do my best to have everything set up and running by next Tuesday. |
Hi, First of all, I would like to better explain the changes compared to version 4.7 and explain the reasons for the choices of version 4.8. The main problem I encounter is that the specification evolves a lot and having Webauthn-1, Webauthn-2 and part of Webauthn-3 together is not that simple. Especially with deprecated things. Having For version 5.0, I decided to create denormalizer objects to divide the logic. All denormalizers glued together under a serializer. Since the Symfony Serializer component is fast and easy to use, I decided to go this way and delegate this task to this component. I know some developers aren't fans of the Symfony ecosystem, but the BC promise is important and overall allows many classes and methods to be removed (#557 shows it significantly decreasing in size). This will help focussing on the implementation details rather than the concersion tasks. Let's get back to this issue. The documentation pages for 4.8 are now online and I keep modifying them. Creating and using the serializer should be very simple. use Webauthn\Denormalizer\WebauthnSerializerFactory;
use Webauthn\PublicKeyCredential;
// $attestationStatementSupportManager is an object you should already have.
$serializer = (new WebauthnSerializerFactory($attestationStatementSupportManager))->create();
$publicKeyCredential = $serializer->deserialize('...the data you need to load...', PublicKeyCredential::class, 'json'); I am sincerely sorry that the migration to this minor version is not going as expected. |
The solution provided works flawlessly. It seems I was using Symfony's SerializerInterface directly without realizing the existence of WebauthnSerializerFactory. Thank you, @Spomky, for the rapid response! |
Hi, I updated the pages for the PHP implementations. Note that I enabled few options on the documentation pages. In particular, you can now ask the IA to help you. The responses are based on the pages content. Feel free to report any error you may find with the link to the GitHub repository on the right side of every pages. |
@Spomky I just want to say thank you for the quick documentation updates! They helped me and now I have my Drupal module working fine with 4.8 thanks to you. Much appreciated! |
Thanks for the updated Documentation, just a small hint as I'm currently testing things and working along the documentation. https://webauthn-doc.spomky-labs.com/pure-php/authenticate-your-users $publicKeyCredentialSource = $authenticatorAssertionResponseValidator->check(
$publicKeyCredentialSource,
$authenticatorAssertionResponse,
$publicKeyCredentialRequestOptions,
'my-application.com'
); this needs a 5th argument ($userHandle). also somewhere was a missing semicolon, but don't remember where anymore ;) - didn't found a easy option to report something small like these both issues on the page itself |
Indeed, it should be |
I close this issue as most of the comments have been taken into account. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
The docs site still shows 4.7 as the latest version, and there are no examples of how to address deprecation warnings added in 4.8.
For example, in the section on Webauthn Server, it says to use
PublicKeyCredentialLoader
, but there is a deprecation warning in 4.8:Also, for
$this->sourceObject = PublicKeyCredentialSource::createFromArray($pk_array)
, there's the following deprecation:I opened the class file, but the class basically consists of a create function, so it seems it's totally dependent on Symfony, which it was not (as I understand it) before. If there's an example of how to get this working, it would also be really helpful.
The text was updated successfully, but these errors were encountered: