-
Notifications
You must be signed in to change notification settings - Fork 55
v1alpha3 - Rename BareMetal to ExistingInfra #224
Conversation
6fc3ed9
to
e6a282f
Compare
In my opinion, "ExistingInfra" is more precise a term than "BYOB". |
e6a282f
to
fb82932
Compare
550d9da
to
2b644aa
Compare
I prefer this one over the other. Couldn't understand what BYOB was in the first ten seconds I looked at it |
Also standardise the import name 'existinginfrav1'
Signed-off-by: Dennis Marttinen <dennis@weave.works>
Signed-off-by: Dennis Marttinen <dennis@weave.works>
I don't know about it in Europe, but BYOB in the US generally means "Bring Your Own Beer." Somehow I don't think that's what @yiannistri has in mind. |
Signed-off-by: Dennis Marttinen <dennis@weave.works>
Signed-off-by: Dennis Marttinen <dennis@weave.works>
@bboreham there's one remaining use of |
Thanks for doing the examples, @twelho. Yes it is best to make everything consistent but I was ok to do it later. I don't believe any of them are covered by CI. |
"BareMetal" may make people think we are pxe-booting, while the point of this provider is to take existing machines that run Linux and bring up a Kubernetes node on them.
"ExistingInfra" was one name proposed, so I made this PR to see how it looked.