Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Bump client-go to version 1.11 #1929

Merged
merged 7 commits into from
Apr 12, 2019
Merged

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Apr 12, 2019

This required:

  • Bumping all the kubernetes dependenices to 1.14
  • Replacing justinbarrick/go-k8s-portforward by 2opremio/go-k8s-portforward
    until Bump go-client to 1.11 oliviabarrick/go-k8s-portforward#6 is merged
  • Running dep ensure -update, needed in order to get a newer version of github.com/Azure/go-autorest (the existing one wasn't compatible with client-go 11.0)

I also bumped mergo to 0.3.7 , in accordance to what client-go vendors

Fixes #1670

Alfonso Acosta added 6 commits April 12, 2019 18:51
This required:
* Bumping all the kubernetes dependenices to 1.14
* Replacing justinbarrick/go-k8s-portforward by 2opremio/go-k8s-portforward
  until oliviabarrick/go-k8s-portforward#6 is merged
The -update bit was needed in order to get a newer version of
github.com/Azure/go-autorest (the existing one wasn't compatible
with client-go 11.0)
@2opremio 2opremio requested a review from hiddeco April 12, 2019 17:10
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bumps look alright to me, go-k8s-portforward fork is justified, CI says it works ✔️ 🚢

@2opremio 2opremio merged commit 2c0176c into fluxcd:master Apr 12, 2019
@2opremio 2opremio deleted the bump-k8s-client-go branch April 12, 2019 17:42
@squaremo squaremo added this to the v1.12.1 milestone Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting vendored version of mergo breaks k8s config merging
3 participants