This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Reimplement --git-poll-interval in Helm operator
#1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
helm/git-poll-interval
branch
from
68040f2
to
17202bd
Compare
squaremo
suggested changes
Apr 9, 2019
hiddeco
force-pushed
the
helm/git-poll-interval
branch
from
17202bd
to
6403643
Compare
This got removed a while ago, and was told to be replaced by `--charts-sync-interval`. The `--charts-sync-interval` flag is however _not_ used to control the polling of git repositories, but to control how often we should look if any mutations have occurred to Helm releases. Add it back to restore the feature and regain control over git polling again.
hiddeco
changed the title
--git-poll-interval for Helm operator--git-poll-interval in Helm operator
hiddeco
force-pushed
the
helm/git-poll-interval
branch
from
6403643
to
41b6b4c
Compare
squaremo
approved these changes
Apr 9, 2019
hiddeco
force-pushed
the
helm/git-poll-interval
branch
from
af8a4a4
to
80d6397
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got removed a while ago, and was told to be replaced by
--charts-sync-interval. The--charts-sync-intervalflag is however not used to control the polling of git repositories, but to control how often we should look if any mutations have occurred to Helm releases.Add it back to restore the feature and regain control over git polling again.