Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Do not require 'values' object in HelmRelease CRD #1824

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Mar 14, 2019

Fixes #1812

People sometimes just want to deploy a chart without setting any custom values. Before this commit this required setting a values: {} in the HelmRelease, which was quite inconvenient.

Change to the CRD only is sufficient as the code already takes, not receiving values, into account.

People sometimes just want to deploy a chart without setting any custom
values. Before this commit this required setting a `values: {}` in the
HelmRelease, which was quite inconvenient.

Change to the CRD only is sufficient as the code already takes, not
receiving values, into account.
@hiddeco hiddeco added the helm label Mar 14, 2019
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks like mergeValues will cope if its (second) argument is nil. Cool.

@hiddeco hiddeco merged commit f42425c into master Mar 14, 2019
@hiddeco hiddeco deleted the helm-op-optional-values branch March 14, 2019 10:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants