This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Resurrect the --docker-config flag for local use #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We deprecated the --docker-config flag when we switched to looking up imagePullSecrets to get credentials. However, it's still useful if you're not using those -- for example, if you don't pull images from the registry, or (less so) if you assign credentials to service accounts. This commit brings the flag back, and implements it by loading the given docker config file, to supplement any credentials found via imagePullSecrets.
aaron7
approved these changes
May 17, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We deprecated the --docker-config flag when we switched to looking up
imagePullSecrets to get credentials. However, it's still useful if
you're not using those -- for example, if you don't pull images from
the registry, or (less so) if you assign credentials to service
accounts.
This commit brings the flag back, and implements it by loading the
given docker config file, to supplement any credentials found via
imagePullSecrets.