Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating from go-kit/kit/log to the slimmer go-kit/log #226

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Migrating from go-kit/kit/log to the slimmer go-kit/log #226

merged 1 commit into from
Oct 15, 2021

Conversation

dannykopping
Copy link
Contributor

go-kit has spun out its logger package, which is all this library uses.

Migrating from go-kit/kit/log to the slimmer go-kit/log
abc38d0 
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@dannykopping dannykopping marked this pull request as draft October 15, 2021 14:55
@dannykopping dannykopping marked this pull request as ready for review October 15, 2021 14:55
bboreham
bboreham approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm; however users should note that Level support does not interop; if they are also using go-kit/kit/log then they need to update.

@dannykopping
Copy link
Contributor Author

I did this for Cortex:
https://github.com/cortexproject/cortex/blob/master/pkg/util/log/log.go#L111

@bboreham
Copy link
Collaborator

Does that work? ISTM any time you have level.Debug from the two libraries one of them is not going to work.

@bboreham bboreham merged commit ebe5bdc into weaveworks:master Oct 15, 2021
@dannykopping dannykopping deleted the dannykopping/go-kit branch October 15, 2021 16:21
dannykopping pushed a commit to dannykopping/loki that referenced this pull request Oct 15, 2021
Updating weaveworks after weaveworks/common#226 was merged
03c2711 
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@dannykopping dannykopping mentioned this pull request Oct 15, 2021
Merged
2 tasks
slim-bean pushed a commit to grafana/loki that referenced this pull request Oct 15, 2021
Replacing go-kit/kit/log with go-kit/log (#4484)
cff8324 
* Replacing go-kit/kit/log with go-kit/log

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>

* Appeasing the f&^$ing linter

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>

* Adding depguard

Cleaning go mod

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>

* Updating weaveworks after weaveworks/common#226 was merged

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>

* Appeasing the mod checker

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@bboreham bboreham mentioned this pull request Oct 22, 2021
Merged
@hairyhenderson hairyhenderson mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannykopping @bboreham